Stefan Beller <sbeller@xxxxxxxxxx> writes: > I guess it is ok for now and in this series, but we may want > to split up diff.[ch] in the future into multiple finer grained files. For what end? Such a split would require more symbols internal to diff.[ch] to become external, which is a big downside, so we need to have a large reward to compensate it if we were to go there.