> 在 2017年5月2日，10:24，Junio C Hamano <gitster@xxxxxxxxx> 写道： > > But I am having a huge problem seeing how this patch is correct. It > always is troubling to see a patch that makes the behaviour of a > program change even when the optional feature it implements is not > being used at all. Why does it even have to touch smtp_auth_maybe? > Why does the updated smtp_auth_maybe have to do quite different > things even when batch-size is not defined from the original? > What is that new "Auth use saved password. \n" message about? You are right！I need to correct this. > After reading the problem description in the proposed log message, > the most natural update to achieve the stated goal is to add code to > the loop that has the only caller to send_message() function, I > would think. The loop goes over the input files and prepares the > variables used in send_message() and have the function send a single > message, initializing $smtp as necessary but otherwise reusing $smtp > the previous round has prepared. So just after $message_id is > undefed in the loop, I expected that you would count "number of > messages sent so far during this session", and when that number > exceeds the batch size, disconnect $smtp and unset the variable, > and sleep for a bit, without having to change anything else. Agree！