On Fri, May 5, 2017 at 11:21 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Fri, 5 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> int cmd_add_interactive__helper(int argc, const char **argv, const char *prefix) >> { >> - int i, found_opt = 0; >> - >> - git_config(git_add_interactive_config, NULL); >> + int opt_status = 0; >> >> - for (i = 1; i < argc; i++) { >> - const char *arg = argv[i]; >> + struct option options[] = { >> + OPT_BOOL(0, "status", &opt_status, >> + N_("print status information with diffstat")), > > Please use OPT_CMDMODE() instead; it was invented exactly for this kind of > scenario. Indeed. Forgot about that. That's much better. >> -- >> 2.11.0 > > Really? ;-) CC-ing the Debian stretch release team with your complaint [not really]. I don't bother to 'make install' the git I'm hacking on, so E-Mail gets sent with whatever's in Debian testing.