On 01/05/17 06:35, Junio C Hamano wrote: > > * nd/fopen-errors (2017-04-23) 17 commits > - warn_failure_to_open_read_optional_path(): a new helper > - t1308: add a test case on open a config directory > - config.c: handle error on failing to fopen() > - xdiff-interface.c: report errno on failure to stat() or fopen() > - wt-status.c: report error on failure to fopen() > - server-info: report error on failure to fopen() > - sequencer.c: report error on failure to fopen() > - rerere.c: report correct errno > - rerere.c: report error on failure to fopen() > - remote.c: report error on failure to fopen() > - commit.c: report error on failure to fopen() the graft file > - log: report errno on failure to fopen() a file > - clone: use xfopen() instead of fopen() > - blame: report error on open if graft_file is a directory > - bisect: report on fopen() error > - config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD > - git_fopen: fix a sparse 'not declared' warning > > We often try to open a file for reading whose existence is > optional, and silently ignore errors from open/fopen; report such > errors if they are not due to missing files. > > Expecting a reroll that would be much simplified thanks to a higher > level helper. Since this "What's cooking", this has been re-rolled, but the "git_fopen: fix a sparse 'not declared' warning" patch has been dropped, so I'm seeing the sparse warning again. Also, this series removes every external caller of the 'warn_on_inaccessible()' function, so this could be marked static in wrapper.c. (I would move the definition of that function above/before warn_on_fopen_errors(), in order not to require a forward declaration). ATB, Ramsay Jones