Re: [PATCH v2 06/21] attr.c: use fopen_or_warn()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 06/21] attr.c: use fopen_or_warn()
From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Date: Wed, 3 May 2017 17:09:51 +0200 (CEST)
Cc: git@xxxxxxxxxxxxxxx, Junio C Hamano <gitster@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Johannes Sixt <j6t@xxxxxxxx>
In-reply-to: <20170503101706.9223-7-pclouds@gmail.com>
References: <20170420112609.26089-1-pclouds@gmail.com> <20170503101706.9223-1-pclouds@gmail.com> <20170503101706.9223-7-pclouds@gmail.com>
User-agent: Alpine 2.20 (DEB 67 2015-01-07)

Hi Duy,


On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>

As commented about warn_on_fopen_errors(), I do not see a benefit in
separating the introduction of this small function from the individual
files' changes to use it. Let's bring it all together.

Ciao,
Dscho

References:
- [PATCH 00/15] Handle fopen() errors
  - From: Nguyễn Thái Ngọc Duy
- [PATCH v2 00/21]
  - From: Nguyễn Thái Ngọc Duy
- [PATCH v2 06/21] attr.c: use fopen_or_warn()
  - From: Nguyễn Thái Ngọc Duy

Prev by Date: Re: [PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()
Next by Date: Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)
Previous by thread: [PATCH v2 06/21] attr.c: use fopen_or_warn()
Next by thread: [PATCH v2 07/21] ident.c: use fopen_or_warn()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]