Re: [PATCH v3 1/6] rebase -i: add abbreviated command-names handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Liam,


On Tue, 2 May 2017, Liam Beguin wrote:

> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> index 2c9c0165b5ab..9b8a030ff045 100644
> --- a/git-rebase--interactive.sh
> +++ b/git-rebase--interactive.sh
> @@ -754,7 +754,7 @@ transform_todo_ids () {
>  	while read -r command rest
>  	do
>  		case "$command" in
> -		"$comment_char"* | exec)
> +		"$comment_char"* |x|exec)

While the existing line has spaces around the pipe symbol, I think you can
safely remove them in this patch, as the style of the remainder of the
script seems to be disagreeing with that style. But please remove also the
space between the `*` and the `|`.

The functional part of the patch is correct, as far as I can see.

Ciao,
Johannes



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]