Re: [PATCH v3 0/5] archive-zip: support files and archives bigger than 4GB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 01.05.2017 um 01:49 schrieb Junio C Hamano:
René Scharfe <l.s.r@xxxxxx> writes:

Am 30.04.2017 um 18:32 schrieb Johannes Sixt:
Am 30.04.2017 um 09:53 schrieb René Scharfe:
@@ -178,7 +182,8 @@ test_expect_success EXPENSIVE,UNZIP 'zip
archive bigger than 4GB' '
      "$GIT_UNZIP" -t many-big.zip
  '

-test_expect_success EXPENSIVE,UNZIP,ZIPINFO 'zip archive with
files bigger than 4GB' '
+test_expect_success
EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \

Why is LONG_IS_64BIT required?

Blob sizes are kept in variables of type unsigned long.  64 bits are
required to store file sizes bigger than 4GB, and this test is about
such a file.  A 32-bit git can't use the pack we supply the test file
in, so we have to skip this test.

+    'zip archive with files bigger than 4GB' '
      # Pack created with:
      #   dd if=/dev/zero of=file bs=1M count=4100 && git
hash-object -w file
      mkdir -p .git/objects/pack &&

OK, so let's queue this on top and have it in 'next' to unblock
users of older unzip and unzip compiled wihtout zip64 support?

Yes, please; it allows them to run t5004 with --long-tests or GIT_TEST_LONG set (but not to actually test zip64 functionality).

René



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]