Junio C Hamano <gitster@xxxxxxxxx> writes: > Johannes Schindelin <johannes.schindelin@xxxxxx> writes: > >> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh >> index 214af0372ba..52a19e0bdb3 100644 >> --- a/git-rebase--interactive.sh >> +++ b/git-rebase--interactive.sh >> @@ -774,11 +774,11 @@ transform_todo_ids () { >> } >> >> expand_todo_ids() { >> - transform_todo_ids >> + git rebase--helper --expand-sha1s >> } >> >> collapse_todo_ids() { >> - transform_todo_ids --short >> + git rebase--helper --shorten-sha1s >> } > > Obviously correct ;-) But doesn't this make transform_todo_ids () > helper unused and removable? Ehh, in case it was notclear, I meant the helper function in shell, not the one you added below to C code. > >> +int transform_todo_ids(int shorten_sha1s) >> +{