On Mon, Apr 24, 2017 at 5:57 PM, Jeff King <peff@xxxxxxxx> wrote: > When we init a submodule, we try to die when it has no URL > defined: > > url = xstrdup(sub->url); > if (!url) > die(...); > > But that's clearly nonsense. xstrdup() will never return > NULL, and if sub->url is NULL, we'll segfault. > > These two bits of code need to be flipped, so we check > sub->url before looking at it. > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- Makes sense. At the time I assumed xstrdup had a _or_null behavior (i.e. if NULL goes in, it is not duplicated, but rather return NULL) Thanks, Stefan