On 5/9/07, Junio C Hamano <junkio@xxxxxxx> wrote:
Nicolas Pitre <nico@xxxxxxx> writes: > So I suggest that we get rid of core.legacyheaders, preserve the legacy > format as the only writable loose object format and deprecate the other > one to keep things simpler. Thoughts? I agree with your analysis, especially when deeper delta chains are allowed, straight copy of loose object becomes less and less likely.
I too agree with the logic in the original <tangential comment>, and deprecation is the appropriate thing. So I'm not actually going to change anything here in today's patch.
> What we need instead is a --no-reuse-object that would force > recompression of everything when you really want to enforce a specific > compression level across the whole pack(s). Yeah. Or maybe --no-reuse to mean both and make '-f' a short-hand synonym for that. I do not see much reason to want to tweak them independently; recomputing delta is much more expensive than recompressing anyway, and when the user says 'repack -f', it is a sign that the user is willing to spend CPU cycles.
We have the same idea about git-repack -f -- it implies both --no-reuse-delta and --no-reuse-object , and I will do that. I will incorporate Nicolas's new --no-reuse-object in my patch to builtin-pack-objects.c . I won't go so far as collapsing --no-reuse-* to --no-reuse in this patch. Thanks, -- Dana L. How danahow@xxxxxxxxx +1 650 804 5991 cell - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
