On 04/19/2017 01:01 PM, Nguyễn Thái Ngọc Duy wrote: > Changes since v2 [1] is relatively small. It still needs > nd/worktree-kill-parse-ref of course. I read the whole series. Aside from the comments I made, it looks good to me. This will be able to be cleaned up once we have a cleaner distinction between "logical" and "physical" ref_stores. But given the current state of the code, your implementation is reasonable. Michael