On 04/21/2017 08:32 AM, Michael Haggerty wrote: > [...] > I've CCed Duy because I don't know whether he has more plans regarding > submodule references [...] get rid of the > `for_each_ref_submodule()` family of functions entirely. > > So perhaps the code that this patch touches won't be around long anyway. Oh yeah, he has done exactly that in his nd/prune-in-worktree patch series. (I knew I'd seen that somewhere...) So it seems that the argument renaming has mostly been overtaken by events, though even after Duy's patch series there are a few `const char *submodule` arguments that could be renamed. Michael