Hi Peff, On Tue, 18 Apr 2017, Jeff King wrote: > On Tue, Apr 18, 2017 at 07:44:21PM +0000, git@xxxxxxxxxxxxxxxxx wrote: > > > From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > > > > Teach register_rename_src() to see if new file pair can simply be > > appended to the rename_src[] array before performing the binary search > > to find the proper insertion point. > > I guess your perf results show some minor improvement. But I suspect > this is because your synthetic repo does not resemble the real world > very much. Please note that the synthetic test repo was added *after* coming up with the patch, *after* performance benchmarking on a certain really big repository (it is not hard to guess what use case we are optimizing, right?). In that light, I would like to register the fact that Jeff's performance work is trying to improve a very real world, that of more than 2,000 developers in our company [*1*]. Ciao, Johannes Footnote *1*: https://twitter.com/GabeAul/status/846189637945110528