Jeff King <peff@xxxxxxxx> writes: > I doubt that doing it in one call matters. It's not like stdio promises > us any atomicity in the first place. > >> - fscanf(fp, "%"SCNuMAX" %127c", &pid, locking_host) == 2 && >> + fscanf(fp, "%"SCNuMAX" ", &pid) == 1 && >> + !strbuf_getwholeline(&locking_host, fp, '\0') && > > I don't think there is anything wrong with using fscanf here, but it has > enough pitfalls in general that I don't really like its use as a parser > (and the general lack of it in Git's code base seems to agree). > > I wonder if this should just read a line (or the whole file) into a > strbuf and parse it there. That would better match our usual style, I > think. Yeah, I think it would be a good change.