On 04/18, Eric Wong wrote:
> > +static int env_isequal(const char *e1, const char *e2)
> > +{
> > + for (;;) {
> > + char c1 = *e1++;
> > + char c2 = *e2++;
> > + c1 = (c1 == '=') ? '\0' : tolower(c1);
> > + c2 = (c2 == '=') ? '\0' : tolower(c2);
>
> Dealing with C strings scares me so maybe I'm misreading;
> but: why is this comparison case-insensitive?
Well i was pulling inspiration from the stuff in mingw.c...looks like i
probably shouldn't have done so as you're correct, they should be
case-sensitive. Jonathan pointed out that doing this env stuff in
vanilla C may not be a good idea...and I kinda forgot about that cause
it worked (it passed tests) Let me re-write this section of code to make
it correct, and saner.
--
Brandon Williams