This is the ninth version of a patch series that implements the GSoC microproject of converting a recursive call to readdir() to use dir_iterator. v1: https://public-inbox.org/git/CAGZ79kZwT-9mHTiOJ5CEjk2wDFkn6+NcogjX0=vjhsAh16ANYg@xxxxxxxxxxxxxx/T/#t v2: https://public-inbox.org/git/CACsJy8Dxh-QPBBLfaFWPAWUsbA9GVXA7x+mXLjEvYKhk1zOpig@xxxxxxxxxxxxxx/T/#t v3: https://public-inbox.org/git/CAGZ79kYtpmURSQWPumobA=e3JBFjKhWCdv_LPhKCd71ZRwMovA@xxxxxxxxxxxxxx/T/#t v4: https://public-inbox.org/git/1490747533-89143-1-git-send-email-bnmvco@xxxxxxxxx/T/#e437a63e0c22c00c69b5d92977c9b438ed2b9fd3a v5: https://public-inbox.org/git/1490844730-47634-1-git-send-email-bnmvco@xxxxxxxxx/T/#m2323f15e45de699f2e09364f40a62e17047cf453 v6: https://public-inbox.org/git/1491107726-21504-1-git-send-email-bnmvco@xxxxxxxxx/T/#t v7: https://public-inbox.org/git/1491163388-41255-1-git-send-email-bnmvco@xxxxxxxxx/T/#t v8: https://public-inbox.org/git/a60b2ed6-2b99-b134-05af-7c8492a6949c@xxxxxxxxxxxx/T/#t Travis CI build: https://travis-ci.org/theiostream/git/builds/222919383 I think this is the closest to a final version we've ever gotten. I followed all of Michael and Stefan's suggestions on top of v8, and with Michael's endorsement made dir_iterator_begin() return NULL and set errno appropriately in case of an error. On second thought, maybe the extra code complexity required from dir_iterator_begin()'s callers might be actually an advantage as dir_iterator grows to tackle more complex dir traversing challenges on Git. After all, we might want some special behavior depending on what the given `path` is instead of always considering it valid and later behaving as if it was an empty directory. Thanks again for the reviews. Daniel Ferreira (5): dir_iterator: add tests for dir_iterator API remove_subtree(): test removing nested directories dir_iterator: add helpers to dir_iterator_advance dir_iterator: refactor state machine model remove_subtree(): reimplement using iterators Makefile | 1 + dir-iterator.c | 252 +++++++++++++++++++++++++++++----------- dir-iterator.h | 35 ++++-- entry.c | 42 +++---- refs/files-backend.c | 51 +++++--- t/helper/.gitignore | 1 + t/helper/test-dir-iterator.c | 53 +++++++++ t/t0065-dir-iterator.sh | 113 ++++++++++++++++++ t/t2000-checkout-cache-clash.sh | 11 ++ 9 files changed, 435 insertions(+), 124 deletions(-) create mode 100644 t/helper/test-dir-iterator.c create mode 100755 t/t0065-dir-iterator.sh -- 2.7.4 (Apple Git-66)