On Fri, Apr 14, 2017 at 5:50 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> As explained in the document. This option has an advantage over the >> command sequence "git worktree add && git worktree lock": there will be >> no gap that somebody can accidentally "prune" the new worktree (or soon, >> explicitly "worktree remove" it). >> >> "worktree add" does keep a lock on while it's preparing the worktree. >> If --lock is specified, this lock remains after the worktree is created. >> >> Suggested-by: David Taylor <David.Taylor@xxxxxxxx> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> A patch that adds --lock may look like this. > > This looks more like "I do believe the idea by David is a useful > addition and here is how I did it to the best of my ability---let's > make sure we polish it for eventual inclusion" than a mere "it may > look like so---do whatever you want with it" patch. It is a good addition, which is why I added tests and documents, so it may have a chance for inclusion. I would not strongly defend it though if there's objection. > To me "git worktree add --lock" somehow sounds less correct than > "git worktree add --locked", but I'd appreciate if natives can > correct me. That was my first choice too. Then I saw --detach (instead of --detached). I didn't care much and went with a verb like the rest. -- Duy