Brandon Williams <bmwill@xxxxxxxxxx> wrote: > On 04/13, Eric Wong wrote: > > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, struct child_err *cerr) > > error_errno("exec '%s': cd to '%s' failed", > > cmd->argv[0], cmd->dir); > > break; > > + case CHILD_ERR_SIGPROCMASK: > > + error_errno("sigprocmask failed restoring signals"); > > missing a break statement here I'll add it in, in the re-roll. Good catch, thanks! > > case CHILD_ERR_ENOENT: > > error_errno("cannot run %s", cmd->argv[0]); > > break;