On Tue, Apr 11, 2017 at 05:56:56PM +0300, Sergey Ryazanov wrote: > > I don't know _what_ "https://"; should do. It's clearly bogus. But > > telling curl to use the defaults seems funny. In that sense, your > > original was much better (we'd feed it to curl, which would be free to > > complain). > > > > I thought about this situation too. IMHO the best solution here is to > check host after credential_from_url() call. If host is NULL then we > should show warning message and exit. Then user could fix its > configuration. > > Since I in any case will send v3 with grammar fixes then I could add > new patch to the series. This new patch will check host for NULL and > print warning message. Are you Ok with such solution? Yeah, I think that would be fine. It pretty clearly seems like an error, so any behavior that isn't "quietly pretend that there is no proxy" is probably fine. -Peff