On Sat, Apr 08, 2017 at 01:25:06PM +0000, Ævar Arnfjörð Bjarmason wrote: > --- a/Makefile > +++ b/Makefile > @@ -32,6 +32,14 @@ all:: > # Define LIBPCREDIR=/foo/bar if your libpcre header and library files are in > # /foo/bar/include and /foo/bar/lib directories. > # > +# Define USE_LIBPCRE if you have and want to use libpcre2. Various > +# commands such as like log, grep offer runtime options to use > +# Perl-compatible regular expressions instead of standard or extended > +# POSIX regular expressions. USE_LIBPCRE2 here, right? I'll admit I skimmed a bit on reading this patch, as I don't know the pcre2 API at all. I didn't see anything that looked obviously wrong, though. -Peff