Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Wed, 5 Apr 2017 13:00:57 -0700
Cc: "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
In-reply-to: <20170405195600.54801-2-git@jeffhostetler.com>
References: <20170405195600.54801-1-git@jeffhostetler.com> <20170405195600.54801-2-git@jeffhostetler.com>

On Wed, Apr 5, 2017 at 12:55 PM,  <git@xxxxxxxxxxxxxxxxx> wrote:
> +       if (list->nr + 1 >= list->alloc)
> +               ALLOC_GROW(list->items, list->nr+1, list->alloc);

No need for the condition here as it is part of the macro as well.

Thanks for spotting this fix!
Stefan

References:
- [PATCH v1 0/2] string-list: use ALLOC_GROW macro when reallocing
  - From: git
- [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
  - From: git

Prev by Date: [PATCH v1 2/2] p0005-status: time status on very large repo
Next by Date: Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
Previous by thread: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
Next by thread: Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]