Hi Brandon, On Tue, 4 Apr 2017, Brandon Williams wrote: > I'm all for seeing a patch like this applied. I agree that we can't > expect the world to be running the most up-to-date version of curl but > we should be able to select some "oldest" version we will support which > can be bumped up every couple of years. > > I mean, ensuring that you are running with an up-to-date version of curl > is really important when it comes to all of the security fixes that have > been made in each revision. I am not in the business of dictating to others what software they have to run. I am in the business of maintaining Git for Windows. And part of that job is to drag along code that is maybe not the most elegant, but works. The patch in question resolves such a wart. Sure, it would be a cleanup. Is it a huge maintenance burden to keep those few #ifdef's, though? Absolutely not. Ciao, Johannes