On Mon, Apr 03, 2017 at 11:57:51PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> +These features can be enabled on git servers, they won't help the > >> +performance of the servers themselves, > > > > Is that true for bitmaps? I thought they reduced CPU usage on > > the server side... > > I'm not sure, JK? From my reading of the repack.writeBitmaps docs it > seems to only help clone/fetch for the client, but maybe they do more > than that. Bitmaps reduce the CPU required to do the "Counting" phase of pack-objects. For serving a fetch or clone, the server side is happy because they use less CPU, but the client is happy because the server moves to the "Writing" phase more quickly. Bitmaps also help with pushes, but this is usually less interesting. You don't tend to push all of history over and over (whereas people _do_ tend to clone all of history over and over). They don't speed up the counting portion of a regular repack. In theory they could, but the resulting packs may grow less optimal over time (e.g., we can't compute the same history-based write order, so over time your objects would get jumbled, leading to worse cold-cache behavior). You can also use bitmaps for other reachability computations, but we don't do so currently. I have patches that I need to clean up to use them for "git prune", doing ahead/behind checks, --contains, etc. > I also see we should mention pack.writeBitmapHashCache, which > according to my reading of v2.0.0-rc0~13^2~8 only helps clone/fetch. Yes, it helps the delta search heuristic, so only pack-objects would ever benefit. This should basically be turned on all the time, as without it fetches from partially-bitmapped repos (i.e., when you've gotten some pushes but haven't repacked yet) do a really bad job of finding deltas (the waste too much time and deliver sub-optimal packs). Arguably it should be the default. The initial patches made it optional for strict JGit compatibility (I don't know if JGit ever implemented the extension). We've had it on at GitHub since day one, so I don't have any operational experience with turning it off (aside from the simulated numbers in that commit message). > > A sidenote: I wonder if bitmaps should be the default for bare > > repos, since bare repos are likely used on servers. That's an interesting notion. It's a net loss if you don't serve a lot of fetches, because it's trying to amortize the extra CPU during the repack with faster fetches and clones. So it makes sense for a hosting site, but less for somebody pushing to a personal bare repo. -Peff