On 03/26/2017 04:42 AM, Nguyễn Thái Ngọc Duy wrote: > v7 is mostly about style changes except the one bug in > test-ref-store.c, missing setup_git_directory(). > > There's one new patch, 03/28, which maps to the "if (!refs)" deletion > in the interdiff. > > The one comment from v6 I haven't addressed in v7 is whether to delete > REF_STORE_READ. But if it is deleted, I think I'm doing it in > nd/worktree-kill-parse-ref, which is partly about cleanup refs code > anyway, to avoid another re-roll in this series. I reviewed v7 pretty carefully, and send a couple of minor comments. But with or without changes, it looks good to me and the whole series is Reviewed-by: Michael Haggerty <mhagger@xxxxxxxxxxxx> Thanks! Michael