Brandon Williams wrote: > Also, clear the push_options string_list to > prevent memory leaking. That's not a real leak, right? Is the motivation to make it not show up in valgrind output? At first it didn't look related to the other change but then the connection dawned on me. > Signed-off-by: Brandon Williams <bmwill@xxxxxxxxxx> > --- > builtin/push.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) For what it's worth, Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>