On Fri, 31 Mar 2017 13:29:04 +0200
"Jessie Hernandez" <git@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, 31 Mar 2017 09:53:38 +0200
> > "Jessie Hernandez" <git@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > [...]
> >> >> It's possible to have ttk with 8.5 as well (say, here on Debian
> >> >> 8.5 ships with ttk enabled).
> >> >>
> >> >> A proper patch would be
> >> >>
> >> >> -set default_config(gui.usettk) 1
> >> >> +set default_config(gui.usettk) [namespace exists ::ttk]
> >> >>
> >> >> Could you please test it on your system?
> >> >>
> >> >
> >> > Yeah that seems to work.
> >> > Thanks for this.
> >> >
> >> > I have tried it with git 2.12.2
> > [...]
> >> I spoke to soon. :(
> >> It does not work. I forgot to do a install when testing.
> >> Sorry for the confusion.
> >
> > Care to elaborate on the exact error, please?
> >
>
> The error I get is the following
>
> Error in startup script: wrong # args: should be "ttk::style theme
> use theme" while executing
> "ttk::style theme use"
> (procedure "ttext" line 4)
> invoked from within
> "ttext $ui_workdir -background white -foreground black \
> -borderwidth 0 \
> -width 20 -height 10 \
> -wrap none \
> -takefocus 1 -highlightthickness 1\
> ..."
> (file "/usr/libexec/git-core/git-gui" line 3190)
Too bad: the git-gui relies on the [ttk::style theme use] command --
that is, the two-argument invocation of [ttk::style] -- to return
the theme being currently in use, and this feature was implemented
on 2008-05-27 [1] by Pat Thoyts.
Judging from the output of
fossil descendants e83b7dd29ddae998f96538584afb518849ac1e2c
the first Tk release to have this change was 8.6b2.
So the proper fix appears to be more involved:
set default_config(gui.usettk) \
[expr {[package vcompare [info patchlevel] 8.6b2] >= 0}]
(The slash+newline sequence is not needed -- it's here mostly
for pretty-printing.)
1. http://core.tcl.tk/tk/info/e83b7dd29ddae998