On Thu, Mar 30, 2017 at 4:06 PM, Jeffrey Walton <noloader@xxxxxxxxx> wrote: > On Wed, Mar 29, 2017 at 1:11 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Jeffrey Walton <noloader@xxxxxxxxx> writes: >> >>> Some more 2.12.2 testing on Solaris 11.3 x86_64: >>> >>> $ make V=1 >>> gcc -o credential-store.o -c -MF ./.depend/credential-store.o.d -MQ >>> credential-store.o -MMD -MP -I/usr/local/include -m64 -m64 -I. >>> -D__EXTENSIONS__ -D__sun__ -DUSE_LIBPCRE -I/usr/local/include >>> -DHAVE_ALLOCA_H -I/usr/local/include -DUSE_CURL_FOR_IMAP_SEND >>> -I/usr/local/include -I/usr/local/include -DNO_D_TYPE_IN_DIRENT >>> -DNO_INET_NTOP -DNO_INET_PTON -DHAVE_PATHS_H -DHAVE_LIBCHARSET_H >> >> Looking at config.mak.uname, nothing in SunOS section seems to set >> NO_INET_NTOP or NO_INET_PTON. Why is your build setting them? > > Thanks. It looks like the following is the culprit (from config.log). > Am I supposed to specify the socket library, or is Autotools supposed > to specify it? > > To date, I've been specify the libraries I request, like IDN2, PCRE, > cURL and OpenSSL. > > I don't recall specifying a socket library in the past, so I'm not > sure what is supposed to happen here. It looks like adding -lnsl and -lsocket clears the issue. Maybe Git on Solaris should test with both of the libraries, and not just -lsockets. Jeff