> From: Junio C Hamano [mailto:gitster@xxxxxxxxx] > > > diff --git a/sub-process.c b/sub-process.c new file mode 100644 index > > 0000000000..2c4d27c193 > > --- /dev/null > > +++ b/sub-process.c > > @@ -0,0 +1,116 @@ > > +/* > > + * Generic implementation of background process infrastructure. > > + */ > > +#include "sub-process.h" > > +#include "sigchain.h" > > +#include "pkt-line.h" > > + ... > > +void subprocess_exit_handler(struct child_process *process) { > > This is not only undocumented in the above, but it does not seem to be > necessary to be a public function. The only thing that uses this is > subprocess_start(), which is in this file. Perhaps make it static? OK. Missed that somehow. I'll fix it and send another patch series.