On 03/29/2017 02:32 AM, Daniel Ferreira wrote:
> Create inline helpers to dir_iterator_advance(). Make
> dir_iterator_advance()'s code more legible and allow some behavior to
> be reusable.
Thanks for breaking up the patches. That makes them a lot easier to review.
> Signed-off-by: Daniel Ferreira <bnmvco@xxxxxxxxx>
> ---
> dir-iterator.c | 65 +++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 42 insertions(+), 23 deletions(-)
>
> diff --git a/dir-iterator.c b/dir-iterator.c
> index 34182a9..853c040 100644
> --- a/dir-iterator.c
> +++ b/dir-iterator.c
> @@ -50,6 +50,43 @@ struct dir_iterator_int {
> struct dir_iterator_level *levels;
> };
>
> +static inline void push_dir_level(struct dir_iterator_int *iter, struct dir_iterator_level *level)
> +{
> + level->dir_state = DIR_STATE_RECURSE;
> + ALLOC_GROW(iter->levels, iter->levels_nr + 1,
> + iter->levels_alloc);
> + level = &iter->levels[iter->levels_nr++];
> + level->initialized = 0;
> +}
> +
> +static inline int pop_dir_level(struct dir_iterator_int *iter, struct dir_iterator_level *level)
> +{
> + return --iter->levels_nr;
> +}
`pop_dir_level()` doesn't use its `level` argument; it can be removed.
> [...]
Michael