On Mon, Mar 27, 2017 at 04:32:10PM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > > Hrm, there shouldn't be any dependency of the config on the index (and > > there are a handful of options which impact the index already). Did you > > try it and run into problems? > > > > In general, I'd much rather see us either: > > > > 1. Rip the code out entirely if it is not meant to be configurable, > > and cannot be triggered by the actual git binary. > > > > or > > > > 2. Make it configurable, even if most people wouldn't use it. And then > > have a test to exercise it using a git command (unlike the one-off > > test helper, which isn't run at all). > > Agreed with this, leaning toward (1). > > If "git fsck" verifies the .git/index file then I don't see any need > for other commands to. Yeah, code that _can_ be run but almost nobody does is possibly worse than code that can't be run. :) I agree that it would make sense for fsck to check it, though (just like it checks the actual pack trailer checksums, even though normal operations do not). -Peff