Re: [PATCH v6 24/27] t/helper: add test-ref-store to test ref-store functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 22, 2017 at 8:37 PM, Jeff King <peff@xxxxxxxx> wrote:
> On Wed, Mar 22, 2017 at 09:34:12AM -0400, Jeff King wrote:
>
>> On Sat, Mar 18, 2017 at 09:03:34AM +0700, Nguyễn Thái Ngọc Duy wrote:
>>
>> > diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
>> > new file mode 100644
>>
>> When nd/files-backend-git-dir is merged to 'next', the new tests in
>> t1405/t1406 break. They need this on top (which should probably just be
>> squashed into this commit when you re-roll).
>>
>> -- >8 --
>> Subject: [PATCH] test-ref-store: setup git directory
>>
>> Without setting up the git directory, we rely on the ".git"
>> fallback in setup_git_env(). This will cause us to abort
>> once b1ef400ee (setup_git_env: avoid blind fall-back to
>> ".git", 2016-10-20) is merged.
>
> After posting this, it occurred to me that "pu" should be showing the
> same failure, but it doesn't. The reason is that e9e167145 (worktree.c:
> kill parse_ref() in favor of refs_resolve_ref_unsafe(), 2017-03-18) from
> nd/worktree-kill-parse-ref sneaks in the setup call.
>
> We should move it back to the addition of test-ref-store, though, since
> nd/files-backend-git-dir may graduate separately.

Right. I needed that setup_git_directory() for the third ref store.
But now that I think about it, I need it for the first two as well
because git_path() is always involved. Will fix (since it looks like
files-backend-git-dir is not merged to next yet).
-- 
Duy




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]