Stefan Beller wrote: > v7: > * taken all of Jonathan minor nits, so patch 1..6 should be good to go > * patch 7 lacks tests and documentation (according to Jonathan...) > but as it is the last patch, just fixing a minor detail we can leave it off. > > Junio, please take patch 1-6 as usual, I will be out until next Wednesday. [...] > Stefan Beller (8): > submodule.c: port is_submodule_modified to use porcelain 2 > submodule.c: use argv_array in is_submodule_modified > submodule.c: convert is_submodule_modified to use > strbuf_getwholeline_fd > submodule.c: port is_submodule_modified to use porcelain 2 > submodule.c: factor out early loop termination in > is_submodule_modified > submodule.c: stricter checking for submodules in is_submodule_modified > short status: improve reporting for submodule changes > submodule.c: correctly handle nested submodules in > is_submodule_modified > > Documentation/git-status.txt | 9 +++++++ > submodule.c | 56 ++++++++++++++++++++----------------------- > t/t3600-rm.sh | 18 ++++++++++---- > t/t7506-status-submodule.sh | 57 ++++++++++++++++++++++++++++++++++++++++++++ > wt-status.c | 13 ++++++++-- > 5 files changed, 116 insertions(+), 37 deletions(-) Patches 1-6 are Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> The effect of patch 7 on --porcelain=2 output is subtle enough that I don't feel I understand it. I think it heads in a good direction but indeed, some tests could help to illustrate the desired behavior. Thanks for your patient work. Jonathan