On Fri, Mar 24, 2017 at 3:38 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > It also overlaps work a little better. mentioned >> Once we know all information that we care about, we can terminate >> the child early. In that case we do not care about its exit code as well. > > Should this say something about SIGPIPE? done > language nit: s/, no output/: neither output/ done > wait_or_whine(cp->pid, cp->argv[0], 1) doesn't do that but is meant for > signal handling. Maybe we should rely on SIGPIPE instead (which > wait_or_whine always silences) and avoid the kill() call. done > Can there be a test for this case (i.e. having lots of untracked files > in the submodule so the child process fills its pipe buffer and has to > exit early)? done