On Thu, Mar 23, 2017 at 11:28:52AM -0700, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > > > This series is the updated version of 'sg/completion-refs-speedup'. > > It speeds up refs completion for large number of refs, partly by > > giving up disambiguating ambiguous refs and partly by eliminating most > > of the shell processing between 'git for-each-ref' and 'ls-remote' and > > Bash's completion facility. The rest is a bit of preparatory > > reorganization, cleanup and bugfixes. > > > > Changes since v1: > > ... > > [1] - http://public-inbox.org/git/20170206181545.12869-1-szeder.dev@xxxxxxxxx/ > > It seems Jacob Keller was the only person who was excited about > these changes when v1 was posted? It would be nice to see a bit > more enthusiasm from other folks who are invested in the completion > script, but you are the de-facto go-to person on the completion > already, so ... ;-) > > Will replace. Let's advance this to 'next' soonish (say, by early > next week). I'm far from an expert in the completion scripts, but I read over the whole thing and it looked good to me. As usual with bash, the optimizations can make the code a bit non-intuitive, but I think the changes are clearly explained and the performance results speak for themselves. -Peff