On Fri, Mar 24, 2017 at 12:49:43PM -0400, Jeff King wrote: > On Fri, Mar 24, 2017 at 09:45:30AM -0700, Junio C Hamano wrote: > > > I actually think this uncovers another class of breakage. t7030 > > tests should be protected with GPG prereq and 'fourth-signed' that > > is made only with the prereq in the first test will not be found. > > It seems like t7030 should just skip_all when the GPG prereq is not > met (it's not wrong to mark each test that's added, but it would have > made this particular mistake harder). > > > t7004 probably has the same issue. > > These ones should be marked individually, though. I started to prepare a patch for t7030, but given that we want to do this all in one patch anyway (for bisectability), I think it probably makes sense to just add the missing GPG prereqs as part of the patch you posted. If somebody wants to convert t7030 to skip_all on top that's fine, but it's not that big a deal. -Peff