On 5/7/07, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
Dana How, Mon, May 07, 2007 19:51:24 +0200: > On 5/7/07, Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > >I'm not sure about fsck cleaning up after crashed/killed pack-objects: > >not sure I _can_ detect if the temp files really are just leftovers. > > It looks like you create temp file in objects , not objects/pack . > > So a rule could be : packs left in the former are crashed/killed, > and packs in the latter are complete? How do you know for sure that they are _left_ already?
Ah, e.g. you're packing and fsck'ing at the same time? Then you can't know. Never mind...
> You should also look at $PACKTMP in git-repack.sh . > In it $GIT_DIR should probably be $GIT_OBJECT_DIRECTORY ? I think it should, but it is already not the working directory, so my original complaint does not apply
OK, if I have to further change my --max-pack-size patchset which touches git-repack.sh, I'll roll this in. Thanks, -- Dana L. How danahow@xxxxxxxxx +1 650 804 5991 cell - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html