2017-03-23 12:03 GMT-06:00 Junio C Hamano <gitster@xxxxxxxxx>: > Alex Henrie <alexhenrie24@xxxxxxxxx> writes: > >> Yes, that makes sense. I assume that when you talk about 'next', you >> mean 'master'? > > No, I do mean 'next'. See "A note from the maintainer" post that > are sent to the list every once in a while (i.e. after a new release > is tagged) for the project structure. > > https://public-inbox.org/git/xmqqy3vztypi.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ That document was very helpful, thanks. >> If we want to use `git -p log` in a test, we'll have to change the >> behavior of pager_in_use(). Alternatively, we could use >> `GIT_PAGER_IN_USE=1 git log` instead. > > Testing "git -p" is not the goal; testing that decorate defaults to > auto during an interactive session is. We could run tests under pty > like t7006 does using lib-terminal.sh if we really want to emulate > an interactive session. > > Exporting GIT_PAGER_IN_USE may be sufficient for the purpose of > convincing the command to be in an interactive session for this > test, even though it feels a bit too brittle to depend on the > internal implementation detail. Okay, I've now written a lib-terminal test for git log. I'll send the revised patch momentarily. -Alex