Stefan Beller wrote:
> struct argv_array is easier to use and maintain
Yes!
[...]
> submodule.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
I also like the diffstat. :)
[...]
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1043,12 +1043,6 @@ unsigned is_submodule_modified(const char *path, int ignore_untracked)
> {
> ssize_t len;
> struct child_process cp = CHILD_PROCESS_INIT;
> - const char *argv[] = {
> - "status",
> - "--porcelain",
> - NULL,
> - NULL,
> - };
and the avoidance of this kind of fixed-size magic.
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Thank you.