Re: [PATCH v1] travis-ci: build and test Git on Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 23 Mar 2017, at 20:30, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> 
> Lars Schneider <larsxschneider@xxxxxxxxx> writes:
> 
>> "[...] we do not provide these values to untrusted builds, 
>> triggered by pull requests from another repository."
>> 
>> See: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
> 
> OK, it is a releaf to see an indication that somebody over there is
> thinking.  Thanks.
> 
> So we do _not_ have to turn it off; as soon as we define sekrit
> variables, they will turn it off for us ;-).
> 
>>> Hrm, it does mean that people have no way to test on Windows until the
>>> branch hits pu. Which is not ideal.
>> 
>> I agree it's not ideal. But I think it is an improvement to check
>> pu/next/master/maint continuously :-)
> 
> I am not sure what you mean.  We are building each and every branch
> updates already, and I do not see any improvement over what we are
> doing now.  Care to elaborate?

We are building each and every branch on TravisCI right now - but 
only on Linux and OSX. With this change we also build it on
Windows. That should help to spot Windows related issues more
quickly I think.

- Lars





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]