On Thu, Mar 23, 2017 at 10:30 AM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: >> Are you sure about that? From what I had looked into userdiff.c, there >> is no support for shell. There just a recent patch for [go patterns][0]. >> Or perhaps I should have rename it as "userdiff.c: patterns for "shell" >> language"? > > I also could not find any shell patterns in the userdiff code... Sorry for the confusion on my part. I am unfamiliar with that part of the diffing lib. I based my assumption on the output of "$ git log -p t/" which contains hunk headers, that make sense most of the time for shell code. > > Careful. It is a ton of work to get the rebase -i conversion done, and > then a ton of work to get it integrated. That will fill 3 months, very > easily. > >> > > What do you think of these projects? Would it collide with Valery >> > > Tolstov's Shell to Builtins proposal? > > I missed that proposal, and could only find submodule-related mails on the > public-inbox server. Care to provide a pointer? Well I don't think it is a full grown proposal, but a confident attempt to find a good starting point :) e.g. https://public-inbox.org/git/1489145258.10535.0@xxxxxxxxxxxxxx/ >> > Curious why all people ask about colliding with Valerys proposal here? >> > I do not think it would collide, as submodules and rebase are very >> > different areas of the code base. > > Indeed ;-) Although I had some discussion on what the correct behavior of "rebase --recurse-submodules" in a superproject should be. But this sounds like future work after the GSoC is over. ;) Thanks, Stefan