Ben Peart <peartben@xxxxxxxxx> writes:
> This code is refactored from:
>
> Commit edcc85814c ("convert: add filter.<driver>.process option", 2016-10-16)
> keeps the external process running and processes all commands
I am afraid that this organization of the patch series is making it
harder than necessary to review, by duplicating the same code first
_WITH_ renaming of symbols, etc., in this step and then updaing the
original callers while removing the now-stale original callee
implementation in a separate next step.
Would it perhaps make it clearer to understand what is going on if
you instead started to update the code in convert.c in place to make
it more suitable fro reuse as the patch title advertises, and then
move the resulting cleaned-up code to a separate file, I wonder.