On 03/22, Junio C Hamano wrote:
> Brandon Williams <bmwill@xxxxxxxxxx> writes:
>
> > Teach remote-curl to understand push options and to be able to convey
> > them across HTTP.
> >
> > Signed-off-by: Brandon Williams <bmwill@xxxxxxxxxx>
> > ---
>
> An earlier 438fc684 ("push options: pass push options to the
> transport helper", 2017-02-08) said:
>
> ...
> Fix this by propagating the push options to the transport helper.
>
> This is only addressing the first issue of
> (1) the helper protocol does not propagate push-option
> (2) the http helper is not prepared to handle push-option
>
> Once we fix (2), the http transport helper can make use of push options
> as well, but that happens as a follow up. (1) is a bug fix, whereas (2)
> is a feature, which is why we only do (1) here.
>
> and this is the step (2) to complete what it started?
Yep! As far as I understand from looking at that commit, push options
were being passed to remote-curl and remote-curl was silently ignoring
them. So that patch made it complain when a remote-helper didn't
support push options.
This patch teaches remote-curl to actually support push options, fixing
(2).
--
Brandon Williams