Just FYI before I start reading each patch carefully... Subject: [PATCH 2/6] hashmap: allow memihash computation to be continued ERROR: trailing whitespace #28: FILE: hashmap.c:56: + */ $ total: 1 errors, 0 warnings, 30 lines checked ------------------------------------------------ Subject: [PATCH 4/6] name-hash: perf improvement for lazy_init_name_hash ERROR: space required after that ',' (ctx:VxV) #57: FILE: name-hash.c:38: + return find_dir_entry__hash(istate, name, namelen, memihash(name,namelen)); ^ ERROR: do not initialise statics to 0 or NULL #105: FILE: name-hash.c:157: +static int lazy_nr_dir_threads = 0; total: 2 errors, 0 warnings, 516 lines checked ------------------------------------------------ Subject: [PATCH 5/6] name-hash: add test-lazy-init-name-hash ERROR: do not initialise statics to 0 or NULL #64: FILE: t/helper/test-lazy-init-name-hash.c:4: +static int single = 0; ERROR: do not initialise statics to 0 or NULL #65: FILE: t/helper/test-lazy-init-name-hash.c:5: +static int multi = 0; ERROR: do not initialise statics to 0 or NULL #67: FILE: t/helper/test-lazy-init-name-hash.c:7: +static int dump = 0; ERROR: do not initialise statics to 0 or NULL #68: FILE: t/helper/test-lazy-init-name-hash.c:8: +static int perf = 0; ERROR: do not initialise statics to 0 or NULL #69: FILE: t/helper/test-lazy-init-name-hash.c:9: +static int analyze = 0; ERROR: do not initialise statics to 0 or NULL #70: FILE: t/helper/test-lazy-init-name-hash.c:10: +static int analyze_step = 0; ERROR: trailing whitespace #215: FILE: t/helper/test-lazy-init-name-hash.c:155: +^I^I^Ielse $ total: 7 errors, 0 warnings, 278 lines checked ------------------------------------------------