On Wed, Mar 22, 2017 at 10:14 AM, <git@xxxxxxxxxxxxxxxxx> wrote: > > During our testing on the Windows source tree (3.1M > files, 500K folders, 450MB index), this change reduced > the runtime of lazy_init_name_hash() from 1.4 to 0.27 > seconds. This sounds promising. :) A fast skim over the code makes me like the code. > hashmap.c | 29 ++- > hashmap.h | 25 ++ Could you add some documentation to Documentation/technical/api-hashmap.txt ? (Bonus points for migrating the documentation inline, c.f. discussion surrounding [1]) [1] https://public-inbox.org/git/20141212212800.GA27451@xxxxxxxx/ > name-hash.c | 490 +++++++++++++++++++++++++++++++++++- AFAICT the new threading is all implicit in name-hash and we do not expose its functionality or tuning knobs outside the testing helper, such that we do not need API documentation here, but only enough code comments to understand the code for maintainability? Thanks, Stefan