Re: [PATCH 18/20] commit_packed_refs(): use reference iteration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 22, 2017 at 09:42:58AM +0100, Michael Haggerty wrote:

> > Should we be checking that peel_error is only PEELED or NON_TAG?
> 
> This is a good question, and it took me a while to figure out the whole
> answer. At first I deleted this check without much thought because it
> was just an internal consistency check that should never trigger. But
> actually the story is more complicated than that.
> 
> Tl;dr: the old code is slightly wrong and I think the new code is correct.

OK, that all makes sense. Thanks for digging.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]