Jeff King <peff@xxxxxxxx> writes: > On Mon, Mar 20, 2017 at 08:56:11PM -0400, Kyle Meyer wrote: > >> These patches follow up on Peff's suggestion to modernize the style in >> t1400-update-ref.sh. >> >> 20170217082253.kxjezkxfqkfxjhzr@xxxxxxxxxxxxxxxxxxxxx >> >> The first two commits aren't concerned with "modernizing" the tests, >> but instead address issues that I noticed while looking more closely >> at t1400. > > Looks good overall to me. Thanks for following up. Thanks for a review. >> I also considered >> >> * making the quoting/spacing/breaks around the test descriptions and >> bodies more consistent, but I think this leads to too much code >> churn. > > I wouldn't mind the churn if you wanted to do it on top, but it's > definitely not necessary. There's nothing in 'pu' right now that touches > the file. Yes. But I do not mind (actually I do prefer) if that "on top" came as a separate follow-up after dust from these 5 settles ;-) Thanks.