On Mon, Mar 20, 2017 at 08:14:20PM +0700, Duy Nguyen wrote:
> On Sun, Mar 19, 2017 at 4:19 AM, brian m. carlson
> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> > This is part 7 in the continuing transition to use struct object_id.
>
> It feels very nice to see many ".hash" and "->hash" go away. Looking
> forward to seeing you kill sha1 in sha1_file.c, object.c and friends.
> That one (and read-cache) must be a battle.
Basically, the next few series look like this:
Part 7 (this one): sha1_array → oid_array
Part 8: lookup_{commit,tree,blob,tag}* and parse_object* [0]
Part 9: get_sha1* → get_oid*
Part 10: refs.c
As I go, I make note of which function calls I tend to modify a lot,
since those tend to be good places to look for future conversions.
sha1_file.c is looking like a good candidate for part 11.
> I'm not familiar with many parts that this series touches so I may
> have missed something subtle, but overall it looks good to me. Thank
> you for working on this.
I think git-contacts picked you because I touched a lot of the shallow
code.
> > I chose not to rename the sha1-array.[ch] files
>
> You'll have to rename sha1_file.c, sha1_name.c too and might start a
> code reorganization revolution by renaming sha1-array.[ch] ;-)
I tend to prefer dashes over underscores, so I fear other people may not
like my renaming decisions very much. I think I'm going to stay out of
it and let someone who cares more make the controversial decisions.
Anyway, I've squashed in some changes and will wait another day or two
for other people to send in feedback before v2.
[0] Looking at it now, I can probably handle lookup_object, too, so I
might stuff that in. That series is already 53 patches, though….
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature