On Sat, Mar 18, 2017 at 8:27 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> But I thought it was very a very bizarre pattern to set us to cmdmode >> = 'l' when we're not in that mode at all just to, as can be seen in >> the diff, get around a slightly more verbose one-time if-check. > > When I wrote my response, I viewed that setting as committing to be > in the "list" mode, not as a workaround. So checking with !cmdmode > to make sure that the command line is not asking to create a tag > makes tons of sense; the new test makes it unreadable from that > point of view. Makes sense. Looking at this more carefully there's never any cases where `create_tag_object && cmdmode == 'l'` is true once we make it past `usage_with_options`, which was the bug I introduced locally which made this whole thing a bit confusing for me. I'll drop this patch from v2.