On Fri, Mar 17, 2017 at 11:47:01AM -0700, Brandon Williams wrote: > While taking a look at this bug I discovered that the test suite doesn't > pass 100% of the test when compiled with the NO_PTHREADS option. The > following tests seem to be failing: > > t1060-object-corruption.sh (Wstat: 256 Tests: 13 Failed: 3) > Failed tests: 7-9 > Non-zero exit status: 1 > t5306-pack-nobase.sh (Wstat: 256 Tests: 4 Failed: 1) > Failed test: 4 > Non-zero exit status: 1 > t5504-fetch-receive-strict.sh (Wstat: 256 Tests: 12 Failed: 2) > Failed tests: 4-5 > Non-zero exit status: 1 > t5530-upload-pack-error.sh (Wstat: 256 Tests: 10 Failed: 1) > Failed test: 10 > Non-zero exit status: 1 > > I didn't take a close look at it but this would seem to indicate that we > don't worry to much about systems without pthreads support. Just food > for thought. Hmm. We used to. What version did you test? Everything passes for me at 0281e487f^ (after that it fails to build). So AFAICT v2.12.0 is the first release which does not work with NO_PTHREADS. -Peff