These functions were originally conceived as wrapper functions similar to xmkstemp(). They were later moved by 463db9b10 (wrapper: move odb_* to environment.c, 2010-11-06). The more appropriate place for a declaration is in cache.h. While we're at it, let's add some basic docstrings. Signed-off-by: Jeff King <peff@xxxxxxxx> --- cache.h | 12 ++++++++++++ git-compat-util.h | 2 -- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/cache.h b/cache.h index c95826971..68ad06e15 100644 --- a/cache.h +++ b/cache.h @@ -1634,6 +1634,18 @@ extern struct packed_git *find_sha1_pack(const unsigned char *sha1, extern void pack_report(void); +/* + * Create a temporary file rooted in the object database directory. + */ +extern int odb_mkstemp(char *template, size_t limit, const char *pattern); + +/* + * Create a pack .keep file in the object database's pack directory, for + * a pack with checksum "sha1". The return value is a file descriptor opened + * for writing, or -1 on error. The name of the keep file is written to "name". + */ +extern int odb_pack_keep(char *name, size_t namesz, const unsigned char *sha1); + /* * mmap the index file for the specified packfile (if it is not * already mmapped). Return 0 on success. diff --git a/git-compat-util.h b/git-compat-util.h index e626851fe..8a4a3f85e 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -798,8 +798,6 @@ extern FILE *xfopen(const char *path, const char *mode); extern FILE *xfdopen(int fd, const char *mode); extern int xmkstemp(char *template); extern int xmkstemp_mode(char *template, int mode); -extern int odb_mkstemp(char *template, size_t limit, const char *pattern); -extern int odb_pack_keep(char *name, size_t namesz, const unsigned char *sha1); extern char *xgetcwd(void); extern FILE *fopen_for_writing(const char *path); -- 2.12.0.623.g86ec6c963